This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-ia64-devel] [Patch 4/4] [RFC] Xwindow: Modify pci_acpi_scan_roo

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [Xen-ia64-devel] [Patch 4/4] [RFC] Xwindow: Modify pci_acpi_scan_root()
From: Jun Kamada <kama@xxxxxxxxxxxxxx>
Date: Tue, 05 Jun 2007 15:16:03 +0900
Cc: Alex Williamson <alex.williamson@xxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 04 Jun 2007 23:14:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070605054711.GB9188%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-ia64-devel-request@lists.xensource.com?subject=help>
List-id: Discussion of the ia64 port of Xen <xen-ia64-devel.lists.xensource.com>
List-post: <mailto:xen-ia64-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-ia64-devel>, <mailto:xen-ia64-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070605131608.140E.KAMA@xxxxxxxxxxxxxx> <20070605054711.GB9188%yamahata@xxxxxxxxxxxxx>
Sender: xen-ia64-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 5 Jun 2007 14:47:11 +0900
Isaku Yamahata <yamahata@xxxxxxxxxxxxx> wrote:

> On Tue, Jun 05, 2007 at 01:29:11PM +0900, Jun Kamada wrote:
> > Could you explain more about the PAGE_SIZE optimization?
> > 
> > Current code merges overlapped address ranges without awareness of
> > PAGE_SIZE and page alignment. Merged address range should
> > be divided by PAGE_SIZE?
> ioremap hypercall works in PAGE_SIZE unit so that we can safely
> enlarge the region to be page aligned.
> What I wanted to suggest is somthing like the followings.
> (I assume that end is inclusive. If wrong, please correct it.)
> static int
> __add_issue_list(unsigned long start, unsigned long end,
>                 ioremap_issue_list_t *top)
> ...
> -       new->start = start;
> -       new->end   = end;
> +       new->start = start & ~(PAGE_SIZE - 1);
> +       new->end   = end | (PAGE_SIZE - 1);

I understand. I will modify my code according to your comment.

Thank you so much.

Jun Kamada
Virtual Systems Development Div.
Platform Technology Development Unit
Fujitsu Ltd.

Xen-ia64-devel mailing list