WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ioemu: Clone ioemu with --depth=1

To: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ioemu: Clone ioemu with --depth=1
From: Jean Guyader <jean.guyader@xxxxxxxxx>
Date: Tue, 1 Nov 2011 22:07:58 +0000
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Jean Guyader <jean.guyader@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 01 Nov 2011 15:10:25 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=r6agtwMGU7PdaDtOENJdPZqXZhl1h1ETJyBSYTTaeNE=; b=eJFbspSors+n0gtq2IXPKMQspnZdSVLkbaM6CeBYEQL9N6r7PH9t9AKPDjZFcXTcVV GvOW3oR22KE2771dTKuMieaPgeKgTIbJoVbsNG1f0WY9HlR+c1QcwWdiPKpoN4+3k4WK VxqNoiVVonA/5zzib27dMYEnJr56szr9kwjt4=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4EB0655F.5080107@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20111101173312.GH20553@xxxxxxxxxxxxxxxxxxxxxxx> <4EB0655F.5080107@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 1 November 2011 21:32, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> On 11/01/2011 01:33 PM, Jean Guyader wrote:
>>
>> Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxx>
>>
>> diff --git a/tools/Makefile b/tools/Makefile
>> index 9389e1f..6c1dfe0 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -92,7 +92,7 @@ ioemu-dir-find:
>>               if [ ! -d ioemu-remote ]; then \
>>                       rm -rf ioemu-remote ioemu-remote.tmp; \
>>                       mkdir ioemu-remote.tmp; rmdir ioemu-remote.tmp; \
>> -                     $(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; \
>> +                     $(GIT) clone --depth=1 $(CONFIG_QEMU) 
>> ioemu-remote.tmp; \
>>                       if [ "$(QEMU_TAG)" ]; then                      \
>>                               cd ioemu-remote.tmp;                    \
>>                               $(GIT) branch -D dummy >/dev/null 2>&1 ||:; \
>
> This will break if QEMU_TAG is pointing to any commit that is more than
> one commit away from a branch or tag in the source repository. In order
> to allow using older xen repositories, this requires that every update
> to QEMU_TAG in xen-*.hg also add a tag or branch to the git repository.
>
> It would be nice if you could use git clone --branch $(QEMU_TAG)
> but this is not supported when $(QEMU_TAG) is a commit ID.
>

Yes, that a good point.
I think we should use --depth=1 only when QEMU_TAG isn't set.

Jean

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel