Re: [Xen-devel] [PATCH] ioemu: Clone ioemu with --depth=1

[Jean Guyader <jean.guyader@xxxxxxxxx>]

On 1 November 2011 21:32, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx> wrote:
> On 11/01/2011 01:33 PM, Jean Guyader wrote:
>>
>> Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxx>
>>
>> diff --git a/tools/Makefile b/tools/Makefile
>> index 9389e1f..6c1dfe0 100644
>> --- a/tools/Makefile
>> +++ b/tools/Makefile
>> @@ -92,7 +92,7 @@ ioemu-dir-find:
>>               if [ ! -d ioemu-remote ]; then \
>>                       rm -rf ioemu-remote ioemu-remote.tmp; \
>>                       mkdir ioemu-remote.tmp; rmdir ioemu-remote.tmp; \
>> -                     $(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; \
>> +                     $(GIT) clone --depth=1 $(CONFIG_QEMU) 
>> ioemu-remote.tmp; \
>>                       if [ "$(QEMU_TAG)" ]; then                      \
>>                               cd ioemu-remote.tmp;                    \
>>                               $(GIT) branch -D dummy >/dev/null 2>&1 ||:; \
>
> This will break if QEMU_TAG is pointing to any commit that is more than
> one commit away from a branch or tag in the source repository. In order
> to allow using older xen repositories, this requires that every update
> to QEMU_TAG in xen-*.hg also add a tag or branch to the git repository.
>
> It would be nice if you could use git clone --branch $(QEMU_TAG)
> but this is not supported when $(QEMU_TAG) is a commit ID.
>

Yes, that a good point.
I think we should use --depth=1 only when QEMU_TAG isn't set.

Jean

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel