WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] ioemu: Clone ioemu with --depth=1

To: Jean Guyader <jean.guyader@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] ioemu: Clone ioemu with --depth=1
From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Date: Tue, 01 Nov 2011 17:32:15 -0400
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Tue, 01 Nov 2011 14:33:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20111101173312.GH20553@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: National Security Agency
References: <20111101173312.GH20553@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20110927 Thunderbird/7.0
On 11/01/2011 01:33 PM, Jean Guyader wrote:
> 
> Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxx>
> 
> diff --git a/tools/Makefile b/tools/Makefile
> index 9389e1f..6c1dfe0 100644
> --- a/tools/Makefile
> +++ b/tools/Makefile
> @@ -92,7 +92,7 @@ ioemu-dir-find:
>               if [ ! -d ioemu-remote ]; then \
>                       rm -rf ioemu-remote ioemu-remote.tmp; \
>                       mkdir ioemu-remote.tmp; rmdir ioemu-remote.tmp; \
> -                     $(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; \
> +                     $(GIT) clone --depth=1 $(CONFIG_QEMU) ioemu-remote.tmp; 
> \
>                       if [ "$(QEMU_TAG)" ]; then                      \
>                               cd ioemu-remote.tmp;                    \
>                               $(GIT) branch -D dummy >/dev/null 2>&1 ||:; \

This will break if QEMU_TAG is pointing to any commit that is more than
one commit away from a branch or tag in the source repository. In order
to allow using older xen repositories, this requires that every update
to QEMU_TAG in xen-*.hg also add a tag or branch to the git repository.

It would be nice if you could use git clone --branch $(QEMU_TAG)
but this is not supported when $(QEMU_TAG) is a commit ID.

-- 
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel