Re: [Xen-devel] [PATCH] ioemu: Clone ioemu with --depth=1

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2011-11-01 at 17:32 -0400, Daniel De Graaf wrote:
> On 11/01/2011 01:33 PM, Jean Guyader wrote:
> > 
> > Signed-off-by: Jean Guyader <jean.guyader@xxxxxxxxxx>
> > 
> > diff --git a/tools/Makefile b/tools/Makefile
> > index 9389e1f..6c1dfe0 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -92,7 +92,7 @@ ioemu-dir-find:
> >             if [ ! -d ioemu-remote ]; then \
> >                     rm -rf ioemu-remote ioemu-remote.tmp; \
> >                     mkdir ioemu-remote.tmp; rmdir ioemu-remote.tmp; \
> > -                   $(GIT) clone $(CONFIG_QEMU) ioemu-remote.tmp; \
> > +                   $(GIT) clone --depth=1 $(CONFIG_QEMU) ioemu-remote.tmp; 
> > \
> >                     if [ "$(QEMU_TAG)" ]; then                      \
> >                             cd ioemu-remote.tmp;                    \
> >                             $(GIT) branch -D dummy >/dev/null 2>&1 ||:; \
> 
> This will break if QEMU_TAG is pointing to any commit that is more than
> one commit away from a branch or tag in the source repository.

Good point. We could do e.g. --depth=2000 which takes history back to
some time in 2007.

On the other hand a full clone takes ~30s and a --depth=2000 takes ~20s
(both elapsed wallclock times) so it's not clear that there is all that
much benefit in the context of how long everything actually takes to
build, especially given the big clone only happens once per build tree.

>  In order
> to allow using older xen repositories, this requires that every update
> to QEMU_TAG in xen-*.hg also add a tag or branch to the git repository.
> 
> It would be nice if you could use git clone --branch $(QEMU_TAG)
> but this is not supported when $(QEMU_TAG) is a commit ID.
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel