|
xen-devel
RE: [Xen-devel] [PATCH] X86: cpuid faulting feature enable
|
To: |
Keir Fraser <keir.xen@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> |
|
Subject: |
RE: [Xen-devel] [PATCH] X86: cpuid faulting feature enable |
|
From: |
"Tian, Kevin" <kevin.tian@xxxxxxxxx> |
|
Date: |
Sat, 2 Jul 2011 11:04:30 +0800 |
|
Accept-language: |
en-US |
|
Acceptlanguage: |
en-US |
|
Cc: |
"xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Shan, Haitao" <haitao.shan@xxxxxxxxx>, "Li, Xin" <xin.li@xxxxxxxxx> |
|
Delivery-date: |
Fri, 01 Jul 2011 20:05:29 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<CA33AF68.1D5C3%keir.xen@xxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<4E0E088A020000780004BB07@xxxxxxxxxxxxxxxxxxxx> <CA33AF68.1D5C3%keir.xen@xxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
Thread-index: |
Acw4CQeVZMnHpMVFU0iR1jrN1b1wSAAW4h/w |
|
Thread-topic: |
[Xen-devel] [PATCH] X86: cpuid faulting feature enable |
> From: Keir Fraser [mailto:keir.xen@xxxxxxxxx]
> Sent: Saturday, July 02, 2011 12:08 AM
>
> On 01/07/2011 16:48, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>
> >> + if ( cpuid_faulting_flip )
> >> + {
> >> + unsigned int enable;
> >> +
> >> + enable = !is_hvm_vcpu(next) && (next->domain->domain_id != 0);
> >
> > Excluding Dom0 here is perhaps questionable (as it could allow hiding
> > features not supported by Xen from applications).
>
> It's probably because of a need for raw cpuid in libxc/xc_cpuid_x86.c where
> we need to detect things like long mode. We could do that another way, or
> provide a new paravirtualised raw cpuid just for dom0.
>
> Not a barrier to this patch going in imo.
>
> I suppose HVM VCPUs are excluded because otherwise the new feature would
> be
> unexpectedly enabled in non-root mode too, and make HVM guests crash? :-)
>
yes, unless we convert GP to cause VM-exit as an alternative. :-)
Thanks
Kevin
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
Home