WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] use of struct hvm_mirq_dpci_mapping.gmsi vs. HVM_IRQ_DPC

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] use of struct hvm_mirq_dpci_mapping.gmsi vs. HVM_IRQ_DPCI_*_MSI flags
From: Haitao Shan <maillists.shan@xxxxxxxxx>
Date: Thu, 28 Apr 2011 09:31:08 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Allen M Kay <allen.m.kay@xxxxxxxxx>
Delivery-date: Wed, 27 Apr 2011 18:32:10 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=KLRgCeO6jE+NLOJKLPGZB6GWpekawA7wHoZxLXWbGnk=; b=WNNDZ597CiUMGKaUb4+eM7B2hw48AhRU46eSewp2r/gtF5VkvRgaFvJJKBl9NudHTw HyvvDIR5cf7cm7PO+cnKOHVinlqIZdPRksatH++Kmz42Y3VLw9DAvxcprlNM8x5ocekN tHMOmUrFYh+DfdGZz2BggjAN2FQSpPeeIj5x4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=CGk6p7hK7681tOzMY6mzBLWh1Mr8hPJfmcq3oO+nMCPLOMSMufOI9xK5lOc66dkrqA gObADbgwmw70whr+xIPMKMZFNNpZfdR93/CSM6xrnOI9shZT+1jRKwiKBcIPegmvD1oW zdelwe451bYtClhKj/hkJWcMu8z4GHPrXoa0g=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4DB7D72A020000780003E4C4@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D94A88C0200007800039637@xxxxxxxxxxxxxxxxxx> <BANLkTinVcOUqDst2nOj8xfzNFbHnEtwCJg@xxxxxxxxxxxxxx> <4DB6A2EE020000780003E1DC@xxxxxxxxxxxxxxxxxx> <987664A83D2D224EAE907B061CE93D5301C50FD4BF@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4DB7D72A020000780003E4C4@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

But clarification on the current (perhaps vs intended) use of
HVM_IRQ_DPCI_*_MSI would still be much appreciated (and if,
as suspected, there's need to clean this up, I'd like the cleanup
to be done before the patches I have pending).

Jan, I think the meaning of the flags are pretty straight forward. But I agree with you, we need to clean this up. I don't believe all the flags are necessary at the moment (given the fact that they are introduced by host-MSI-to-guest-INTx translation). But it is still OK for me if they did not cause trouble and were not wrongly used.
I wonder whether the original patch has carefully considered the usage of these flags when it tried to introduce these flags by nature.
 
Basically, I think it is up to you to decide their (flags) future. You are already very careful on this. :) 
 
Shan Haitao 
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel