WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] PVops domain 0 crash on NUMA system only Node==1 present

To: Vincent Caron <vcaron@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] PVops domain 0 crash on NUMA system only Node==1 present (Was: Re: Bug#603632: linux-image-2.6.32-5-xen-amd64: Linux kernel 2.6.32/xen/amd64 booting fine on bare metal, but not as dom0 with Xen 4.0.1 (Dell R410))
From: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Date: Fri, 3 Dec 2010 08:51:04 +0000
Cc: Jeremy Fitzhardinge <jeremy@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Vincent CARON <zerodeux@xxxxxxxxxxxx>, Cris Daniluk <cris.daniluk@xxxxxxxxx>, "603632@xxxxxxxxxxxxxxx" <603632@xxxxxxxxxxxxxxx>
Delivery-date: Fri, 03 Dec 2010 00:52:05 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1291333639.25131.48.camel@zerohal>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <20101115233253.11935.35707.reportbug@zerohal> <1290513067.31507.7699.camel@xxxxxxxxxxxxxxxxxxxxxx> <1290538327.9844.26.camel@xxxxxxxxxxxxxxxxxxxxx> <1290550323.9844.85.camel@xxxxxxxxxxxxxxxxxxxxx> <1290550726.9844.90.camel@xxxxxxxxxxxxxxxxxxxxx> <1291333639.25131.48.camel@zerohal>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Thu, 2010-12-02 at 23:47 +0000, Vincent Caron wrote:
> On Tue, 2010-11-23 at 22:18 +0000, Ian Campbell wrote:
> > On Tue, 2010-11-23 at 22:12 +0000, Ian Campbell wrote: 
> > > On Tue, 2010-11-23 at 18:52 +0000, Ian Campbell wrote: 
> > > > On Tue, 2010-11-23 at 11:51 +0000, Ian Campbell wrote:
> > > > > 
> > > > > Perhaps we should be passing numa_node_id() (e.g. current node)
> > > > > instead of node 0? 
> > > > 
> > > > I've just kicked off a build of the 2.6.32-27 Debian kernel with the
> > > > following additional patch, I will hopefully post the binaries tomorrow.
> > > 
> > > Build was quicker than I thought... Vincent, Cris if you get a chance
> > > please can you test the kernel from:
> > > http://xenbits.xen.org/people/ianc/2.6.32-27+numa1/
> > 
> > Also, please can you try adding "numa=noacpi" to your kernel command
> > line when running with the standard Debian kernel (not the one above).
> > 
> > Thanks!
> 
>   It just happens that your kernel above (2.6.32-27+numa1) boots fine
> under hypervisor _when_ passed 'numa=noacpi'. Yeah !
> 
>   I then tried again with Debian Squeeze's latest 2.6.32-28, which
> crashes as -27 under hypervisor (and changelog show no xen or
> numa-related thingies). Then I added 'numa=noacpi', and it boots fine
> too. I got my 8 cores, networking, etc.
> 
>   Enclosed is the dmesg for the latter, Debian, kernel.
> 
>   Is the 'numa=noacpi' a "production acceptable" workaround ?

Yes and in fact I think the actual fix is simply to have Xen fake out
the behaviour of numa=noacpi as below. I'll send this plus the other fix
out after I've given it a bit of proper testing.

Ian.

xen: disable ACPI NUMA for PV guests

Xen does not currently expose PV-NUMA information to PV
guests. Therefore disable NUMA for the time being.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 02c710b..5c55e1b 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1178,6 +1178,10 @@ asmlinkage void __init xen_start_kernel(void)
 
        xen_smp_init();
 
+#ifdef CONFIG_ACPI_NUMA
+       acpi_numa = -1;
+#endif
+
        pgd = (pgd_t *)xen_start_info->pt_base;
 
        if (!xen_initial_domain())



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>