WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/Xen merg

To: Pasi Kärkkäinen <pasik@xxxxxx>, <anthony.perard@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge.
From: Keir Fraser <keir@xxxxxxx>
Date: Fri, 29 Oct 2010 14:18:29 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 29 Oct 2010 06:19:14 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=iHJxD1I7nsZQfeT/lhlJCqVvfew5MajZD8LdqUUbc3c=; b=CdLO9NU4+U6gsHYbMZthB4+c9oDg3CqH5fJh9GZ7sqFMuBup7Iux718B+xRazaeQ+G 1lMODDlAJirw36/B4XwlSvhof4pcruVDhuTamap1Rhm155I2iJhCgMbRrF2P2YSf58Tg eTwuAAiV4z/ghTFPSlrtpdxVKVw8zuwhoIiI4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=C1J64fJaSMkGF95nRYIDgQhp1Q8AyOcKOoRLt8AentLpK2N+ufeoPytcX8sC5f+ijn EKR7AeF35K0AyPGVY6kXMVO1Qmhap6zeDru00PUXC52f6e/K9EmFIUnRGCeg8tmoQKQ3 WG/wrhSKaoM3cibMQa+tAjaanDNsY/XpWsSLM=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C8F087D8.8A86%keir@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Act3a49THOaYcsqpC0GM7xzz66hu+AAADdve
Thread-topic: [Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge.
User-agent: Microsoft-Entourage/12.26.0.100708
On 29/10/2010 14:16, "Keir Fraser" <keir@xxxxxxx> wrote:

>> Should it be called something else than HVM_PARAM_ACPI_NEW_IOPORT ?
>> After a couple of years "NEW" might not make much sense anymore..
>> 
>> IOPORT_V2 ? Or something..
> 
> I've asked for a nice big explanatory comment to be added beside the
> parameter's definition. Also we should treat this field as a version number,
> so baking a fixed version into its name is not a good idea. With the
> explanatory comment, I think its existing name is good enough. To do much
> better the name would have to become cumbersomely long.

That said, HVM_PARAM_ACPI_IOPORTS_LOCATION might be better... I'm not
personally that fussed either way however.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel