Re: [Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/

To:	Pasi Kärkkäinen <pasik@xxxxxx>, <anthony.perard@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge.
From:	Keir Fraser <keir@xxxxxxx>
Date:	Fri, 29 Oct 2010 14:16:56 +0100
Cc:	Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 29 Oct 2010 06:17:57 -0700
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:user-agent:date :subject:from:to:cc:message-id:thread-topic:thread-index:in-reply-to :mime-version:content-type:content-transfer-encoding; bh=5z3HXJHEggO6k19a6W+sjxSWlB0R16xC3dJV/AISPyc=; b=BYOs+ygVm6vEeIcZtEiXWC9JAAX4/tXKpgjw+gDakich/adj139rK9Sx/wH2Ln8eFU bBOAL3/YGHaNUeFUpEOuaP4Y2xCi6ktlMLrfWvCogw9lYX3F56xjxvZCnt+JYrYQu2Sy N3hCppxutAoQYUzlX73Y9i2w2kKhgMWVo4PYw=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=DMlLFyeds/M/ExzTkVj0QcVSsPvwNqOLpRHIdodBeoBTC9alnWzNMdW11KRGpCQS6s i9C/JMShzQ9+G4CpQkVYa7N1LU5siRtnzQGsh2kJxfQqwwMbuH/+2bL5Sa+9dISWGtQ3 1DaxNoyQWnKcyZpxcK8zNcBoXzoR6vyCoF2K4=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<20101029131110.GN2804@xxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Act3a49THOaYcsqpC0GM7xzz66hu+A==
Thread-topic:	[Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge.
User-agent:	Microsoft-Entourage/12.26.0.100708

On 29/10/2010 14:11, "Pasi Kärkkäinen" <pasik@xxxxxx> wrote:

>> Xen will register the old ioport by default and switch to the new ioport if
>> the
>> HVM_PARAM_ACPI_NEW_IOPORT is set. So, this series come with a new function,
>> unregister_io_handler, and a new HVM_PARAM.
>> 
> 
> Should it be called something else than HVM_PARAM_ACPI_NEW_IOPORT ?
> After a couple of years "NEW" might not make much sense anymore..
> 
> IOPORT_V2 ? Or something..

I've asked for a nice big explanatory comment to be added beside the
parameter's definition. Also we should treat this field as a version number,
so baking a fixed version into its name is not a good idea. With the
explanatory comment, I think its existing name is good enough. To do much
better the name would have to become cumbersomely long.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH V3 0/6] firmware changes as part of QEMU/Xen merg