WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH 3/5] xen: events: push setup of irq<->{evtchn, pirq}

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] [PATCH 3/5] xen: events: push setup of irq<->{evtchn, pirq} maps into irq_info init functions
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Mon, 25 Oct 2010 17:23:31 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Campbell <ian.campbell@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "H. Peter Anvin" <hpa@xxxxxxxxx>, mingo@xxxxxxx, tglx@xxxxxxxxxxxxx
Delivery-date: Mon, 25 Oct 2010 09:36:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1288023736.11153.40.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1288023736.11153.40.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 drivers/xen/events.c |   23 +++++++++--------------
 1 files changed, 9 insertions(+), 14 deletions(-)

diff --git a/drivers/xen/events.c b/drivers/xen/events.c
index 33fae3d..94055ea 100644
--- a/drivers/xen/events.c
+++ b/drivers/xen/events.c
@@ -137,6 +137,7 @@ static struct irq_info *info_for_irq(unsigned irq)
 
 /* Constructors for packed IRQ information. */
 static void xen_irq_info_common_init(struct irq_info *info,
+                                    unsigned irq,
                                     enum xen_irq_type type,
                                     unsigned short evtchn,
                                     unsigned short cpu)
@@ -147,6 +148,8 @@ static void xen_irq_info_common_init(struct irq_info *info,
        info->type = type;
        info->evtchn = evtchn;
        info->cpu = cpu;
+
+       evtchn_to_irq[evtchn] = irq;
 }
 
 static void xen_irq_info_evtchn_init(unsigned irq,
@@ -154,7 +157,7 @@ static void xen_irq_info_evtchn_init(unsigned irq,
 {
        struct irq_info *info = info_for_irq(irq);
 
-       xen_irq_info_common_init(info, IRQT_EVTCHN, evtchn, 0);
+       xen_irq_info_common_init(info, irq, IRQT_EVTCHN, evtchn, 0);
 }
 
 static void xen_irq_info_ipi_init(unsigned irq,
@@ -163,18 +166,17 @@ static void xen_irq_info_ipi_init(unsigned irq,
 {
        struct irq_info *info = info_for_irq(irq);
 
-       xen_irq_info_common_init(info, IRQT_IPI, evtchn, 0);
+       xen_irq_info_common_init(info, irq, IRQT_IPI, evtchn, 0);
 
        info->u.ipi = ipi;
 }
-
 static void xen_irq_info_virq_init(unsigned irq,
                                   unsigned short evtchn,
                                   unsigned short virq)
 {
        struct irq_info *info = info_for_irq(irq);
 
-       xen_irq_info_common_init(info, IRQT_VIRQ, evtchn, 0);
+       xen_irq_info_common_init(info, irq, IRQT_VIRQ, evtchn, 0);
 
        info->u.virq = virq;
 }
@@ -188,12 +190,14 @@ static void xen_irq_info_pirq_init(unsigned irq,
 {
        struct irq_info *info = info_for_irq(irq);
 
-       xen_irq_info_common_init(info, IRQT_PIRQ, evtchn, 0);
+       xen_irq_info_common_init(info, irq, IRQT_PIRQ, evtchn, 0);
 
        info->u.pirq.pirq = pirq;
        info->u.pirq.gsi = gsi;
        info->u.pirq.vector = vector;
        info->u.pirq.flags = flags;
+
+       pirq_to_irq[pirq] = irq;
 }
 
 /*
@@ -668,11 +672,9 @@ int xen_map_pirq_gsi(unsigned pirq, unsigned gsi, int 
shareable, char *name)
 
        xen_irq_info_pirq_init(irq, 0, pirq, gsi, irq_op.vector,
                               shareable ? PIRQ_SHAREABLE : 0);
-       pirq_to_irq[pirq] = irq;
 
 out:
        spin_unlock(&irq_mapping_update_lock);
-
        return irq;
 }
 
@@ -696,7 +698,6 @@ void xen_allocate_pirq_msi(char *name, int *irq, int *pirq)
                                      handle_level_irq, name);
 
        xen_irq_info_pirq_init(*irq, 0, *pirq, 0, 0, 0);
-       pirq_to_irq[*pirq] = *irq;
 
 out:
        spin_unlock(&irq_mapping_update_lock);
@@ -811,7 +812,6 @@ int bind_evtchn_to_irq(unsigned int evtchn)
                set_irq_chip_and_handler_name(irq, &xen_dynamic_chip,
                                              handle_fasteoi_irq, "event");
 
-               evtchn_to_irq[evtchn] = irq;
                xen_irq_info_evtchn_init(irq, evtchn);
        }
 
@@ -844,7 +844,6 @@ static int bind_ipi_to_irq(unsigned int ipi, unsigned int 
cpu)
                        BUG();
                evtchn = bind_ipi.port;
 
-               evtchn_to_irq[evtchn] = irq;
                xen_irq_info_ipi_init(irq, evtchn, ipi);
                per_cpu(ipi_to_irq, cpu)[ipi] = irq;
 
@@ -879,7 +878,6 @@ int bind_virq_to_irq(unsigned int virq, unsigned int cpu)
                        BUG();
                evtchn = bind_virq.port;
 
-               evtchn_to_irq[evtchn] = irq;
                xen_irq_info_virq_init(irq, evtchn, virq);
 
                per_cpu(virq_to_irq, cpu)[virq] = irq;
@@ -1185,7 +1183,6 @@ void rebind_evtchn_irq(int evtchn, int irq)
           so there should be a proper type */
        BUG_ON(info->type == IRQT_UNBOUND);
 
-       evtchn_to_irq[evtchn] = irq;
        xen_irq_info_evtchn_init(irq, evtchn);
 
        spin_unlock(&irq_mapping_update_lock);
@@ -1312,7 +1309,6 @@ static void restore_cpu_virqs(unsigned int cpu)
                evtchn = bind_virq.port;
 
                /* Record the new mapping. */
-               evtchn_to_irq[evtchn] = irq;
                xen_irq_info_virq_init(irq, evtchn, virq);
                bind_evtchn_to_cpu(evtchn, cpu);
 
@@ -1340,7 +1336,6 @@ static void restore_cpu_ipis(unsigned int cpu)
                evtchn = bind_ipi.port;
 
                /* Record the new mapping. */
-               evtchn_to_irq[evtchn] = irq;
                xen_irq_info_ipi_init(irq, evtchn, ipi);
                bind_evtchn_to_cpu(evtchn, cpu);
 
-- 
1.5.6.5


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>