[Xen-devel] Re: [PATCH] pyGrub: Implement error handling on kernel/initrd extraction

[Paolo Bonzini <pbonzini@xxxxxxxxxx>]

On 07/27/2010 10:49 AM, Michal Novotny wrote:
> On 07/26/2010 05:23 PM, Ian Jackson wrote:
> > Michal Novotny writes ("[Xen-devel] [PATCH] pyGrub: Implement error
> > handling on kernel/initrd extraction"):
> > > Since we agreed that introduction of dom0-min-space is not the right way
> > > to go, it's superseeded by this patch.
> > ...
> > > - os.write(tfd, data)
> > > - os.close(tfd)
> > > + try:
> > > + os.write(tfd, data)
> > > + os.close(tfd)
> > > + except OSError, e:
> > > + print>>sys.stderr, "pyGrub: %s" % str(e)
> > > + sys.exit(1)
> > Thanks, but this is not even slightly correct.
> >
> > Ian.
> Why not? It's been tested and working fine. The try/except block is
> working fine and sys.exit(1) is necessary to terminate pyGrub.
If os.write gets the OSError it will write the error message as part of 
the backtrace, and exit anyway.
That said I could reproduce the failure Michal started from, which is 
this error:
Error creating domain: (1, 'Internal error', 'xc_dom_do_gunzip: inflate 
failed (rc=-5)\\n')
But I think xend can be forgiven for not treating very well about 
out-of-disk-space situations... let's just not care.
Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel