WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] pyGrub: Implement error handling on kernel/initr

To: Michal Novotny <minovotn@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] pyGrub: Implement error handling on kernel/initrd extraction
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 26 Jul 2010 16:23:48 +0100
Cc: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 26 Jul 2010 08:25:49 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C4D94D8.3040609@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: chiark.mail.xen.devel
References: <4C4D94D8.3040609@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Michal Novotny writes ("[Xen-devel] [PATCH] pyGrub: Implement error handling on 
kernel/initrd extraction"):
> Since we agreed that introduction of dom0-min-space is not the right way 
> to go, it's superseeded by this patch.
...
> -        os.write(tfd, data)
> -        os.close(tfd)
> +        try:
> +            os.write(tfd, data)
> +            os.close(tfd)
> +        except OSError, e:
> +            print >>sys.stderr, "pyGrub: %s" % str(e)
> +            sys.exit(1)

Thanks, but this is not even slightly correct.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel