WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH] pyGrub: Implement error handling on kernel/initrd ex

To: "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] pyGrub: Implement error handling on kernel/initrd extraction
From: Michal Novotny <minovotn@xxxxxxxxxx>
Date: Mon, 26 Jul 2010 15:59:52 +0200
Delivery-date: Mon, 26 Jul 2010 07:02:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100430 Fedora/3.0.4-3.fc13 Thunderbird/3.0.4
Hi,
this is the patch to implement error handling on kernel/initrd extraction to pyGrub. There was no error handling before my patch applied and this patch adds error handling code to kernel/initrd extraction for write code. When dom0 is running out of space the standard OSError is being printed to stderr and then pygrub exists when an error on writing those files occured.

This was tested on RHEL-5 dom0 with upstream Xen-4.1 unstable installed with RHEL-5 i386 PV guest for both cases when dom0 had enough space and when it didn't. For the case where there were not enough space on dom0 it returned the error "pyGrub: [Errno 28] No space left on device" and then failed with "Boot loader didn't return any data" message. For dom0 with enough space the PV guest was started successfully.

Since we agreed that introduction of dom0-min-space is not the right way to go, it's superseeded by this patch.

Michal

Signed-off-by: Michal Novotny <minovotn@xxxxxxxxxx>

--
Michal Novotny<minovotn@xxxxxxxxxx>, RHCE
Virtualization Team (xen userspace), Red Hat

Attachment: xen-unstable-pygrub-fix-error-handling.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>