WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH]: fix crash in various tools by permitting xs_*()

To: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH]: fix crash in various tools by permitting xs_*() with NULL path
From: Paolo Bonzini <pbonzini@xxxxxxxxxx>
Date: Mon, 26 Jul 2010 11:45:28 +0200
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Delivery-date: Mon, 26 Jul 2010 02:46:26 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:newsgroups:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=Riaw4gE7/7neLdp/S0wyTDtiUacXCACw+GouQ0j05xw=; b=FcGDtCCRf3TejDBxrBEqOxzIJQnb/Rq4cNhE/Et5o9PDcdhcZLKMqoxXR9b3KxiYOq 8ecmbuT7M8ZtQ9Vh22Vk9IHC3VQEDhRhE++SyEmaEeZKMLhDF/pgezmwgQx2+KnCg12B awxSGDJDF6J7cpX3jH7wjizn3fEDcp+GOlGeI=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:newsgroups:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; b=CY/n8jxJTe028duwrse0crKp+6fCaUdjRZOh4stU0Ywa/1RpSfgLLfrT2m4lWu5ZGy a8Tq52O5zopIWj3mRTCPa2rqEXvGsba5JHwFi/fg9g2JBn49fVN4y6Xy0TpEtbmGBQoB C81HzkSGRv2tS6HyBvSSKJFPqjjzv/A/tZZ6I=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1279645377.1723.1966.camel@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Newsgroups: gmane.comp.emulators.xen.devel
References: <1279641356.1723.1940.camel@xxxxxxxxxxxxxxxxxxxxxx> <19525.52837.149559.660268@xxxxxxxxxxxxxxxxxxxxxxxx> <1279645377.1723.1966.camel@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5
On 07/20/2010 07:02 PM, Gianni Tedesco wrote:
On the contrary open(NULL, O_RDONLY) will... The difference is FILE * is
a struct wheras the change I am proposing in this case is to treat NULL
as the empty string in the case of paths.

Returning EFAULT is one possible outcome, but a SIGSEGV or SIGBUS is also valid according to POSIX.

Paolo

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel