WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]: fix crash in various tools by permitting xs_*()

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]: fix crash in various tools by permitting xs_*() with NULL path
From: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Date: Wed, 21 Jul 2010 09:41:12 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>
Delivery-date: Wed, 21 Jul 2010 01:41:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19525.52837.149559.660268@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Citrix Systems, Inc.
References: <1279641356.1723.1940.camel@xxxxxxxxxxxxxxxxxxxxxx> <19525.52837.149559.660268@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2010-07-20 at 17:27 +0100, Ian Jackson wrote:
> 
> Finally, to review this patch, it would be much more helpful if you
> used a diff tool which includes the function name in the diff output.
> Without that we have to apply the patch to a tree of our own and
> regenerate the diff.

The lack of this has annoyed me about mercurial for some time and this
message provoked me into looking again at how to make it work. So for
the benefit of others:

"hg diff -p" seems to work (this option didn't exist last time I looked,
which I admit was years ago) and adding 
        [diff]
        showfunc = True
to ~/.hgrc also works and seems to extend to "hg email" and "hg
tip" (which do not take a -p) as well so is probably sufficient for most
usecases.

Hurrah.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel