WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Xen-4.0.0 RC9 Test Report. Xen: #21087 & Dom0: #4ebd13..

To: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, "Xu, Jiajun" <jiajun.xu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Xen-4.0.0 RC9 Test Report. Xen: #21087 & Dom0: #4ebd13...
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 07 Apr 2010 08:44:38 +0100
Cc:
Delivery-date: Wed, 07 Apr 2010 00:44:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <789F9655DD1B8F43B48D77C5D30659731D686E86@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrVZdWHsO3qziLZSsizoRLuswj0mgAB+wXDAADHFWAAK+m8XQAAgIkwAADpasg=
Thread-topic: [Xen-devel] Xen-4.0.0 RC9 Test Report. Xen: #21087 & Dom0: #4ebd13...
User-agent: Microsoft-Entourage/12.24.0.100205
On 07/04/2010 08:24, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx> wrote:

>> I looked at the code again, and are you sure about this? As in, have you
>> seen the assertion trigger? The check that current is the idle_vcpu is only
>> made 'if(switch_required)', and that can only be the case if we are running
>> the idle_vcpu! So I think my patch is good as it is, would you agree?
> 
> Aha, yes, you are right, the patch is correct.
> I tested your patch in my first round (I added the _redudant_ check in the
> second round:$ ) and didn't trigger the assertion, the first round runs for
> about 900 round before triger another bug. So, yes, it's a wrong alarm.

I applied the patch as xen-unstable:21109. It actually includes a further
change, to add an extra BUG()-check to cpu_exit_clear(). I think it should
work fine.

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel