This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel] [PATCH] x86/hvm: accelerate I/O intercept handling

To: Andre Przywara <andre.przywara@xxxxxxx>
Subject: RE: [Xen-devel] [PATCH] x86/hvm: accelerate I/O intercept handling
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Thu, 1 Apr 2010 13:15:08 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Wed, 31 Mar 2010 22:15:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BB31F08.20403@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BB30C2A.4020408@xxxxxxx> <ED3036A092A28F4C91B0B4360DD128EABE0C080F@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4BB31F08.20403@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcrQuhuQjChInUeWTsCbU01iocip+gAk9Ycg
Thread-topic: [Xen-devel] [PATCH] x86/hvm: accelerate I/O intercept handling
Andre Przywara wrote:
> Cui, Dexuan wrote:
>> Actually in 15425:6e934c799051, VMX  once enabled the feature, but
>> IIRC, later Keir removed that in some cleanup patches and let the
>> EXIT_REASON_IO_INSTRUCTION handler invoke handle_mmio() also -- I
>> don't remember how people commented the slowness of IN/OUT emulation
>> caused the change...
> If I got this correctly, 15425 introduces only the OUTS/INS segment
Oh... sorry, my memory was bad...

> decoding feature, something that SVM does not have (yet ;-)
> As I said in my mail, I doubt the usefulness of the shortcut in this
> case, since it would require to access the guest memory and is used
> very rarely. So for the sake of a saner implementation I would avoid
> utilizing this feature, it simplifies the code much and avoids code
> duplication. That's why my code just implements non-string
> instructions. 
>> One thing is: IIRC, old Intel CPUs don't supply the info, but your
>  > patch doesn't check that... so your patch can break the CPUs.
>  > Please refer to 15425.
> But this is only true for the segment decoding part, right? Appendix G
> of the Intel 3B manual only speaks of _this_ feature protected by bit
> 54 of IA32_VMX_BASIC MSR. Is the information shown in table 23-5 in
> section 
> 23.2.1 not valid on all CPUs? If not, where can I check the support
> for this?
I mistook IN/OUT for INS/OUTS here. Sorry.
The patch looks good to me.

-- Dexuan

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>