|
|
|
|
|
|
|
|
|
|
xen-devel
[Xen-devel] Re: [LKML] [PATCH 7/7] xen: Enable grant table and xenbus fo
To: |
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> |
Subject: |
[Xen-devel] Re: [LKML] [PATCH 7/7] xen: Enable grant table and xenbus for PV extension of HVM |
From: |
Ian Campbell <Ian.Campbell@xxxxxxxxxx> |
Date: |
Tue, 2 Mar 2010 14:09:55 +0000 |
Cc: |
xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <Jeremy.Fitzhardinge@xxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Sheng Yang <sheng@xxxxxxxxxxxxxxx> |
Delivery-date: |
Tue, 02 Mar 2010 06:10:28 -0800 |
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxxx |
In-reply-to: |
<20100302134127.GA25893@xxxxxxxxxxxxxxxxxxx> |
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
List-post: |
<mailto:xen-devel@lists.xensource.com> |
List-subscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
List-unsubscribe: |
<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
Organization: |
Citrix Systems, Inc. |
References: |
<1267436315-24486-1-git-send-email-sheng@xxxxxxxxxxxxxxx> <1267436315-24486-8-git-send-email-sheng@xxxxxxxxxxxxxxx> <20100301173858.GJ7881@xxxxxxxxxxxxxxxxxxx> <201003020921.43398.sheng@xxxxxxxxxxxxxxx> <20100302134127.GA25893@xxxxxxxxxxxxxxxxxxx> |
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Tue, 2010-03-02 at 13:41 +0000, Konrad Rzeszutek Wilk wrote:
> On Tue, Mar 02, 2010 at 09:21:43AM +0800, Sheng Yang wrote:
> > On Tuesday 02 March 2010 01:38:58 Konrad Rzeszutek Wilk wrote:
> > > > +/* The region reserved by QEmu for Xen platform device */
> > > > +#define GNTTAB_START 0xf2000000ul
> > > > +#define GNTTAB_SIZE 0x20000ul
> > >
> > > I thought that in the earlier review you said:
> > >
> > > "> > +#define GNTTAB_START 0xfbfe0000ul
> > >
> > > > > +#define GNTTAB_SIZE 0x20000ul
> > > >
> > > > Is it possible that there would be a PCI device that would be
> > > > passed in the guest that would conflict with the above mentioned
> > > > E820 region?
> > >
> > > I would change them to a dedicated PCI MMIO address in the next version.
> > > Thanks.
> > >
> > > "
> > > ?
> >
> > And yes, this is the dedicated PCI MMIO address I mentioned.. I would
> > update
> > the comments to get it more clear.
> >
> > I don't think it's very clear solution, because the real good way to do
> > this
> > is probe pci device and find out with one is the platform pci device then
> > use
> > it. But the grant table initialization is quite earlier compared to the
> > possible probing now... I hardcode the position now, and hunting for a
> > better
>
> Would it be possible to move the grant table initialization to later
> phase? Past the PCI loading/initialization?
Or provide the address via an MSR, hypervisor specific CPUID leaf or IO
port or by using the early_pci infrastructure in the kernel. I don't
think we are short of options ;-)
Ian.
>
> > idea.
> >
> > Comments?
> >
> > --
> > regards
> > Yang, Sheng
> >
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
|
|