This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [LKML] [PATCH 7/7] xen: Enable grant table and xenbus fo

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: [Xen-devel] Re: [LKML] [PATCH 7/7] xen: Enable grant table and xenbus for PV extension of HVM
From: Sheng Yang <sheng@xxxxxxxxxxxxxxx>
Date: Tue, 2 Mar 2010 09:21:43 +0800
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Ian Pratt <Ian.Pratt@xxxxxxxxxxxxx>, Jeremy Fitzhardinge <jeremy.fitzhardinge@xxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 01 Mar 2010 17:21:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20100301173858.GJ7881@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Intel Opensource Technology Center
References: <1267436315-24486-1-git-send-email-sheng@xxxxxxxxxxxxxxx> <1267436315-24486-8-git-send-email-sheng@xxxxxxxxxxxxxxx> <20100301173858.GJ7881@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.12.2 (Linux/2.6.31-19-generic; KDE/4.3.2; x86_64; ; )
On Tuesday 02 March 2010 01:38:58 Konrad Rzeszutek Wilk wrote:
> > +/* The region reserved by QEmu for Xen platform device */
> > +#define GNTTAB_START           0xf2000000ul
> > +#define GNTTAB_SIZE            0x20000ul
> I thought that in the earlier review you said:
> "> > +#define GNTTAB_START           0xfbfe0000ul
> > > +#define GNTTAB_SIZE            0x20000ul
> >
> > Is it possible that there would be a PCI device that would be
> > passed in the guest that would conflict with the above mentioned
> > E820 region?
> I would change them to a dedicated PCI MMIO address in the next version.
> Thanks.
> "
> ?

And yes, this is the dedicated PCI MMIO address I mentioned.. I would update 
the comments to get it more clear.

I don't think it's very clear solution, because the real good way to do this 
is probe pci device and find out with one is the platform pci device then use 
it. But the grant table initialization is quite earlier compared to the 
possible probing now... I hardcode the position now, and hunting for a better 


Yang, Sheng

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>