WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables c

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Fri, 26 Feb 2010 09:24:38 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc:
Delivery-date: Thu, 25 Feb 2010 17:26:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C7AC94BF.B648%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E6467867A6B05E4FA831B7DF29925F5C40BBA48B@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <C7AC94BF.B648%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acq13lKhxRtlttZBS6OrDhFD9qjUSwAftU23AAlFEiA=
Thread-topic: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case
Keir Fraser wrote:
> On 25/02/2010 05:49, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
> 
>> ACPI: workaround for S3 fail in two facs tables case
>> 
>> Some legacy BIOS which support ACPI2.0+ may expose two FACS tables
>> via both FADT->FIRMWARE_CTRL and FADT->X_FIRMWARE_CTRL, but only
>> lookup S3 waking_vector in the first one. So enhance the
>> X_FIRMWARE_CTRL selection condition by adding FADT->FIRMWARE_CTRL ==
>> 0. 
>> 
>> Signed-off-by: Wei Gang <gang.wei@xxxxxxxxx>
> 
> I reworked the patch to warn just the same as a native Linux kernel,
> and applied as changeset xen-unstable:20981.

Your change is fine. Thanks --Jimmy
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel