 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables
| To: | Jan Beulich <JBeulich@xxxxxxxxxx>, Gang Wei <gang.wei@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Thu, 25 Feb 2010 10:39:22 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Thu, 25 Feb 2010 02:40:26 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4B86452C020000780003136C@xxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acq19fbDYZJR6LiZR0KjjVgoaBghBQAENPrg |
| Thread-topic: | [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case |
| User-agent: | Microsoft-Entourage/12.23.0.091001 |
On 25/02/2010 08:38, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote: >> /* Now FACS... */ >> - if (fadt->header.revision >= FADT2_REVISION_ID) >> + if (fadt->header.revision >= FADT2_REVISION_ID && fadt->facs == 0) >> facs_pa = fadt->Xfacs; >> else >> facs_pa = (uint64_t)fadt->facs; > > Wouldn't that generally suppress using fadt->Xfacs, since I think in > order to be pre-2.0-OS compatible a BIOS would not normally set > facs to zero when Xfacs is non-zero? Or is that a requirement by the > spec? Good question would be: What does Linux do here? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Re: pvops: i915 kms crashs with corrupt page table, Bastian Blank |
|---|---|
| Next by Date: | Re: [Xen-devel] Crash during boot in Debian lenny default dom0 kernel (2.6.26-2-xen-686), George Dunlap |
| Previous by Thread: | Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case, Jan Beulich |
| Next by Thread: | RE: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case, Wei, Gang |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
