WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables c

To: "Wei, Gang" <gang.wei@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 25 Feb 2010 20:57:35 +0000
Cc:
Delivery-date: Thu, 25 Feb 2010 12:58:35 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <E6467867A6B05E4FA831B7DF29925F5C40BBA48B@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acq13lKhxRtlttZBS6OrDhFD9qjUSwAftU23
Thread-topic: [Xen-devel] [PATCH]ACPI: workaround for S3 fail in two facs tables case
User-agent: Microsoft-Entourage/12.23.0.091001
On 25/02/2010 05:49, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:

> ACPI: workaround for S3 fail in two facs tables case
> 
> Some legacy BIOS which support ACPI2.0+ may expose two FACS tables via both
> FADT->FIRMWARE_CTRL and FADT->X_FIRMWARE_CTRL, but only lookup S3
> waking_vector in the first one. So enhance the X_FIRMWARE_CTRL selection
> condition by adding FADT->FIRMWARE_CTRL == 0.
> 
> Signed-off-by: Wei Gang <gang.wei@xxxxxxxxx>

I reworked the patch to warn just the same as a native Linux kernel, and
applied as changeset xen-unstable:20981.

 Thanks,
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel