|  |  | 
  
    |  |  | 
 
  |   |  | 
  
    |  |  | 
  
    |  |  | 
  
    |   xen-devel
[Xen-devel] Re: [PATCH 04/15] [swiotlb] Search and replace	s/io_tlb/iomm 
| To: | Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> |  
| Subject: | [Xen-devel] Re: [PATCH 04/15] [swiotlb] Search and replace	s/io_tlb/iommu_sw->/ |  
| From: | Chris Wright <chrisw@xxxxxxxxxxxx> |  
| Date: | Thu, 14 Jan 2010 17:43:30 -0800 |  
| Cc: | chrisw@xxxxxxxxxxxx, jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx,	Ian.Campbell@xxxxxxxxxxxxx, joerg.roedel@xxxxxxx,	fujita.tomonori@xxxxxxxxxxxxx, iommu@xxxxxxxxxxxxxxxxxxxxxxxxxx,	dwmw2@xxxxxxxxxxxxx, alex.williamson@xxxxxx |  
| Delivery-date: | Thu, 14 Jan 2010 17:44:09 -0800 |  
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |  
| In-reply-to: | <1263510064-16788-5-git-send-email-konrad.wilk@xxxxxxxxxx> |  
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |  
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |  
| List-post: | <mailto:xen-devel@lists.xensource.com> |  
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |  
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>,	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |  
| References: | <1263510064-16788-1-git-send-email-konrad.wilk@xxxxxxxxxx>	<1263510064-16788-2-git-send-email-konrad.wilk@xxxxxxxxxx>	<1263510064-16788-3-git-send-email-konrad.wilk@xxxxxxxxxx>	<1263510064-16788-4-git-send-email-konrad.wilk@xxxxxxxxxx>	<1263510064-16788-5-git-send-email-konrad.wilk@xxxxxxxxxx> |  
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |  
| User-agent: | Mutt/1.5.19 (2009-01-05) |  
| * Konrad Rzeszutek Wilk (konrad.wilk@xxxxxxxxxx) wrote:
> We also fix the checkpatch.pl errors that surfaced during
> this conversion.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> ---
>  lib/swiotlb.c |  204 
> +++++++++++++++++++++++++++++----------------------------
>  1 files changed, 104 insertions(+), 100 deletions(-)
> 
> diff --git a/lib/swiotlb.c b/lib/swiotlb.c
> index e84f269..3499001 100644
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -176,14 +176,14 @@ EXPORT_SYMBOL(swiotlb_register_engine);
>  
>  void swiotlb_print_info(void)
>  {
> -     unsigned long bytes = io_tlb_nslabs << IO_TLB_SHIFT;
> +     unsigned long bytes = iommu_sw->nslabs << IO_TLB_SHIFT;
This isn't a bisect friendly way to do this...this would oops w/
iommu_sw == NULL.
thanks,
-chris
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 | 
 
| <Prev in Thread] | Current Thread | [Next in Thread> |  | 
[Xen-devel] Re: [PATCH 01/15] [swiotlb] fix: Update	'setup_io_tlb_npages' to accept both arguments in either order., Chris Wright[Xen-devel] [PATCH 15/15] [swiotlb] Take advantage of	iommu_sw->name and add %s to printk's., (continued)
[Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check	iommu_sw pointer., Chris Wright
[Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check	iommu_sw pointer., Konrad Rzeszutek Wilk
[Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check	iommu_sw pointer., Chris Wright
[Xen-devel] Re: [PATCH 06/15] [swiotlb] In 'swiotlb_init' take	advantage of the default swiotlb_engine support., Chris Wright
[Xen-devel] Re: [PATCH 06/15] [swiotlb] In 'swiotlb_init' take	advantage of the default swiotlb_engine support., Konrad Rzeszutek Wilk
[Xen-devel] Re: [PATCH 05/15] [swiotlb] Respect the io_tlb_nslabs	argument value., Chris Wright
[Xen-devel] Re: [PATCH 04/15] [swiotlb] Search and replace	s/io_tlb/iommu_sw->/,
Chris Wright <=
[Xen-devel] Re: [PATCH 04/15] [swiotlb] Search and replace	s/io_tlb/iommu_sw->/, Konrad Rzeszutek Wilk
[Xen-devel] Re: [PATCH 03/15] [swiotlb] Add swiotlb_register_engine	function., Chris Wright
[Xen-devel] Re: [PATCH 03/15] [swiotlb] Add swiotlb_register_engine	function., Konrad Rzeszutek Wilk
[Xen-devel] Re: [PATCH 02/15] [swiotlb] Add swiotlb_engine	structure for tracking multiple software IO TLBs., Chris Wright
[Xen-devel] Re: [PATCH 02/15] [swiotlb] Add swiotlb_engine	structure for tracking multiple software IO TLBs., Konrad Rzeszutek Wilk
[Xen-devel] Re: [PATCH 02/15] [swiotlb] Add swiotlb_engine	structure for tracking multiple software IO TLBs., Chris Wright
[Xen-devel] Re: [PATCH 02/15] [swiotlb] Add swiotlb_engine structure for tracking	multiple software IO TLBs., FUJITA Tomonori
[Xen-devel] Re: [PATCH 02/15] [swiotlb] Add swiotlb_engine	structure for tracking multiple software IO TLBs., Konrad Rzeszutek Wilk
 |  |  | 
  
    |  |  |