[Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check

* Konrad Rzeszutek Wilk (konrad.wilk@xxxxxxxxxx) wrote:
> --- a/lib/swiotlb.c
> +++ b/lib/swiotlb.c
> @@ -364,7 +364,7 @@ cleanup1:
>  
>  void __init swiotlb_free(void)
>  {
> -     if (!iommu_sw->overflow_buffer)
> +     if (!iommu_sw)
>               return;
>  

Sure this is safe for the case where allocation failed?  Wouldn't this
do free_late_bootmem(__pa(0))?

thanks,
-chris

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH 09/15] [swiotlb] Add 'dma_capable' to the swiotlb_ops structure., (continued) [Xen-devel] [PATCH 09/15] [swiotlb] Add 'dma_capable' to the swiotlb_ops structure., Konrad Rzeszutek Wilk [Xen-devel] [PATCH 10/15] [swiotlb] Replace the [phys, bus]->virt and virt->[bus, phys] functions with iommu_sw calls., Konrad Rzeszutek Wilk [Xen-devel] [PATCH 11/15] [swiotlb] Replace late_alloc with iommu_sw->priv usage., Konrad Rzeszutek Wilk [Xen-devel] [PATCH 12/15] [swiotlb] Remove un-used static declerations obsoleted by iommu_sw., Konrad Rzeszutek Wilk [Xen-devel] [PATCH 13/15] [swiotlb] Make io_tlb_nslabs visible outside lib/swiotlb.c and rename it., Konrad Rzeszutek Wilk [Xen-devel] [PATCH 14/15] [swiotlb] Move initialization (swiotlb_init) and its friends in swiotlb-default.c, Konrad Rzeszutek Wilk [Xen-devel] [PATCH 15/15] [swiotlb] Take advantage of iommu_sw->name and add %s to printk's., Konrad Rzeszutek Wilk [Xen-devel] Re: [PATCH 14/15] [swiotlb] Move initialization (swiotlb_init) and its friends in swiotlb-default.c, Chris Wright [Xen-devel] Re: [PATCH 14/15] [swiotlb] Move initialization (swiotlb_init) and its friends in swiotlb-default.c, Konrad Rzeszutek Wilk [Xen-devel] Re: [PATCH 14/15] [swiotlb] Move initialization (swiotlb_init) and its friends in swiotlb-default.c, Chris Wright [Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check iommu_sw pointer., Chris Wright <= [Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check iommu_sw pointer., Konrad Rzeszutek Wilk [Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check iommu_sw pointer., Chris Wright [Xen-devel] Re: [PATCH 06/15] [swiotlb] In 'swiotlb_init' take advantage of the default swiotlb_engine support., Chris Wright [Xen-devel] Re: [PATCH 06/15] [swiotlb] In 'swiotlb_init' take advantage of the default swiotlb_engine support., Konrad Rzeszutek Wilk [Xen-devel] Re: [PATCH 05/15] [swiotlb] Respect the io_tlb_nslabs argument value., Chris Wright [Xen-devel] Re: [PATCH 04/15] [swiotlb] Search and replace s/io_tlb/iommu_sw->/, Chris Wright [Xen-devel] Re: [PATCH 04/15] [swiotlb] Search and replace s/io_tlb/iommu_sw->/, Konrad Rzeszutek Wilk [Xen-devel] Re: [PATCH 03/15] [swiotlb] Add swiotlb_register_engine function., Chris Wright [Xen-devel] Re: [PATCH 03/15] [swiotlb] Add swiotlb_register_engine function., Konrad Rzeszutek Wilk [Xen-devel] Re: [PATCH 02/15] [swiotlb] Add swiotlb_engine structure for tracking multiple software IO TLBs., Chris Wright

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [PATCH 07/15] [swiotlb] In 'swiotlb_free' check iommu_sw