WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] x86: fix MCE/NMI injection

To: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Subject: [Xen-devel] Re: [PATCH] x86: fix MCE/NMI injection
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 01 Dec 2009 11:00:50 +0000
Cc: Yunhong Jiang <yunhong.jiang@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Liping Ke <liping.ke@xxxxxxxxx>
Delivery-date: Tue, 01 Dec 2009 03:01:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200912011139.25978.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B14F1CA0200007800022CC6@xxxxxxxxxxxxxxxxxx> <200912011139.25978.Christoph.Egger@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Christoph Egger <Christoph.Egger@xxxxxxx> 01.12.09 11:39 >>>
>Just a minor nit: your cmpxchgptr() implementation
>looks very complicated and unreadable.

Do you have suggestions for how to improve it without losing the type
correctness checks? (And I really just cloned x86-64's cmpxchg(), so it
shouldn't be that much worse than already existing code.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>