WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] EPT: Flush running cpus, add mask to flush w

To: "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] EPT: Flush running cpus, add mask to flush when scheduled in
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Tue, 22 Sep 2009 10:02:01 +0100
Cc: Xiaohui Xin <Xiaohui.xin@xxxxxxxxx>, Xin Li <xin.b.li@xxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 22 Sep 2009 02:03:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C6DE4776.1563C%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C6DE4445.15636%keir.fraser@xxxxxxxxxxxxx> <C6DE4776.1563C%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir.fraser@xxxxxxxxxxxxx> 22.09.09 10:20 >>>
>On 22/09/2009 09:07, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:
>
>> On 22/09/2009 08:07, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:
>> 
>>> Passing a pointer to the global cpu mask looks racy here: What if a CPU
>>> disappears from domain_dirty_cpumask under your feet?
>> 
>> I'm fixing this race before I apply the patch.
>
>George, Jan,
>
>Please see what you think of xen-unstable:20244.

With no assertion in ept_sync_domain() on any locks held, is it guaranteed
that the function cannot be entered twice at the same time for a given
guest? If not, passing a pointer to the new ept_synced member isn't any
better than passing the one to domain_dirty_cpumask.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel