WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] 2.6.30 dom0 Xen patches

To: Boris Derzhavets <bderzhavets@xxxxxxxxx>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
From: Pasi Kärkkäinen <pasik@xxxxxx>
Date: Fri, 17 Jul 2009 13:06:44 +0300
Cc: Andrew Lyon <andrew.lyon@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Kris Shannon <kris@xxxxxxxxxxxxx>
Delivery-date: Fri, 17 Jul 2009 03:07:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <854047.3663.qm@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <854047.3663.qm@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-08-11)
On Fri, Jul 17, 2009 at 12:11:18AM -0700, Boris Derzhavets wrote:
> 
> I  made two replacements 
> CONFIG_SPARSE_IRQ by CONFIG_GENERIC_HARDIRQS.
> 
> ****************************************************
> In 60035_xen3-patch-2.6.29.patch1 line 11568
> ****************************************************
> +#ifdef CONFIG_SPARSE_IRQ
> + irq_to_desc(irq)->kstat_irqs[cpu] = 0;
> +#else
> kstat_cpu(cpu).irqs[irq] = 0;
> ****************************************************
> In 60036_xen3-patch-2.6.30.patch1 line 18283
> ****************************************************
> +#ifdef CONFIG_SPARSE_IRQ
> +int __init arch_probe_nr_irqs(void)
> +{
> + int nr;
> +
> + if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
> + nr_irqs = NR_VECTORS * nr_cpu_ids;
> 
> To fix this issue. But, i don't know how to rebuild Andy's patch set
> based on your commit.
> 
> Boris.
> P.S.  I haven't heard from Andy for a while.
> 

Boris: Just generate a new (additional) patch that fixes the problem with
CONFIG_SPARSE_IRQ. Much easier for other people to apply it then, and get it
right.. also no need to explain many times what to change and where.. 

-- Pasi

> --- On Thu, 7/16/09, Kris Shannon <kris@xxxxxxxxxxxxx> wrote:
> 
> From: Kris Shannon <kris@xxxxxxxxxxxxx>
> Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
> To: "Andrew Lyon" <andrew.lyon@xxxxxxxxx>
> Cc: "Xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
> Date: Thursday, July 16, 2009, 6:56 PM
> 
> 2009/7/2 Andrew Lyon <andrew.lyon@xxxxxxxxx>:
> > I have rebased the xen-patches from opensuse
> > kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
> > vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
> > available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
> > , if you are not using Gentoo simply apply the patches in numeric
> > order.
> >
> > Some notes:
> >
> > both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
> > 64 bit dom0/domU requires CONFIG_IA32_EMULATION=y
> >
> > Andy
> 
> The error:
> drivers/xen/core/evtchn.c: In function 'unbind_from_irq':
> drivers/xen/core/evtchn.c:641: error: 'struct kernel_stat' has no
> member named 'irqs'
> 
> when CONFIG_SPARSE_IRQ is not set is due to a missing #ifdef change a couple
> of lines earlier.  The commit d52a61c04c6c0814ca270a088feedb126436598e altered
> the kernel_stat.irqs dependency to CONFIG_GENERIC_HARDIRQS.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 
> 
> 
>       
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel