Re: [Xen-devel] 2.6.30 dom0 Xen patches

[Boris Derzhavets <bderzhavets@xxxxxxxxx>]

I still believe in 60035_xen3-patch-2.6.29.patch1 line 11568 

+#ifdef CONFIG_SPARSE_IRQ
+                       irq_to_desc(irq)->kstat_irqs[cpu] = 0;
+#else
                        kstat_cpu(cpu).irqs[irq] = 0;

causes a problem.
Working xenified 2.6.30.1 kernel may be built changing one more dependency

Boris.

--- On Fri, 7/10/09, Boris Derzhavets <bderzhavets@xxxxxxxxx> wrote:

From: Boris Derzhavets <bderzhavets@xxxxxxxxx>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Andrew Lyon" <andrew.lyon@xxxxxxxxx>, "Jan Beulich" <JBeulich@xxxxxxxxxx>
Cc: "Xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Date: Friday, July 10, 2009, 5:31 AM

The first time and  it's in this tread (about week ago), captured entries and selected the only one 2.6.30 patch file follow you instruction,
as i understood it - 60036_xen3-patch-2.6.30.patch1

All entries found :-

-# if !defined(CONFIG_SPARSE_IRQ) && NR_CPUS < MAX_IO_APICS
-# elif defined(CONFIG_SPARSE_IRQ) && 8 * NR_CPUS > 32 * MAX_IO_APICS
+# elif defined(CONFIG_SPARSE_IRQ)
+#ifdef CONFIG_SPARSE_IRQ

I've just replaced in 60036_xen3-patch-2.6.30.patch1

+#ifdef CONFIG_SPARSE_IRQ
   by
+#ifdef CONFIG_GENERIC_HARDIRQS

due to my understanding term dependency ( it might be wrong )

Then applied Andy's patch set and built 2.6.30 xenified kernel with no errors.
This kernel at runtime has serious bugs with loading PV drivers in HVM
and STUB domains. So, is pretty much useless

In case of 2.6.30.1 vanilla kernel this step doesn't help anymore.
Compilation fails in same place ( same function).

Even been compiled with CONFIG_SPARSE_IRQ=y in .config 2.6.30.1
xenified kernel doesn't have bug mentioned above and it's very important.

Thank you.
Boris

--- On Fri, 7/10/09, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:

From: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Andrew Lyon" <andrew.lyon@xxxxxxxxx>, "Boris Derzhavets" <bderzhavets@xxxxxxxxx>
Cc: "Xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Date: Friday, July 10, 2009, 4:55 AM

>>> Boris Derzhavets <bderzhavets@xxxxxxxxx> 10.07.09 10:26 >>>
>Actually, manually setting  CONFIG_SPARSE_IRQ=y in .config also allows
>to build working xenified 2.6.30.1 kernel for C2D & Q9550 CPUs .
>But, you've also criticize this action.

I didn't. All I said is that the build succeeding shouldn't depend on what value
you select here.

>If it's not a secret ,please, explain how to change dependency in 2.6.30
>patch properly ?

Quoting my earlier mail:

>> May I ask why you found the first and third ones to be necessary? Unless
>> it's because of the conditional in the loop right after the commen "Zap
>> stats across IRQ changes of use." in unbind_from_irq(), which I fixed a
>> few days ago, but didn't push out to our internal repo so far. (The fix
>> is to change the dependency from CONFIG_SPARSE_IRQ to
>> CONFIG_GENERIC_HARDIRQS in the 2.6.30 patch.)

And there I meant *only* this one place, not a general replacement
everywhere in the patches (and in particular not in the .29 one).

If that isn't enough, you'll have to let me know what build issue you still
encounter.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

-----Inline Attachment Follows-----

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel