Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs

On Tuesday 16 June 2009 10:30:57 Jan Beulich wrote:
> >>> Christoph Egger <Christoph.Egger@xxxxxxx> 15.06.09 17:33 >>>
> >
> >@@ -174,8 +177,11 @@ wakeup_64:
> >         mov     $(__HYPERVISOR_DS64), %eax
> >         mov     %eax, %ds
> >
> >-        # long jump to return point, with cs reload
> >-        rex64 ljmp    *ret_point(%rip)
> >+        /* Continue with wakeup in the high-level wakeup code.
> >+         * Reload cs there.
> >+         */
> >+        movq    ret_point(%rip), %rbx
> >+        jmp     *%rbx
> >
> >         .align 8
> > ret_point:
>
> Why do you add a comment ("Reload cs here") here that is not in sync with
> the changed code?

Re-read: You missed the "t"
:)

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] How to Allocate Disk Bandwidth among VMs?, Tom Creck

Next by Date:

[Xen-devel] Dedicating a physical CPU core to a VM, Kumar, Venkat

Previous by Thread:

Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs, Jan Beulich

Next by Thread:

Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs, Keir Fraser

Indexes:

[Date] [Thread] [Top] [All Lists]