 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs
| To: | Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Fri, 05 Jun 2009 09:21:26 +0100 |
| Cc: | |
| Delivery-date: | Fri, 05 Jun 2009 01:22:00 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <200906051000.52397.Christoph.Egger@xxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcnltDVUZB64iK0pSXqJ2mVh8WyyqQAAmkDO |
| Thread-topic: | [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs |
| User-agent: | Microsoft-Entourage/12.17.0.090302 |
On 05/06/2009 09:00, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote: > attached patch fixes S3 resume on AMD CPUs. > > Signed-off-by: Christoph Egger <Christoph.Egger@xxxxxxx> Please make a minimal patch and explain each individual change. This one has bizarre additional alignment, nops, double short jumps, longjmp->shortjmp but keeps a comment which is then incorrect. Why are they needed? Is the need documented? I don't see anything similar in Linux 2.6.27 wakeup routines (2.6.27 is what I happen to have to hand). I won't take your random permutations on this file of all files especially, since it is a pain in the arse to debug when it gets broken. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs, Christoph Egger |
|---|---|
| Next by Date: | Re: [Xen-devel] Future of xenbits Linux trees, Pasi Kärkkäinen |
| Previous by Thread: | [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs, Christoph Egger |
| Next by Thread: | Re: [Xen-devel] [PATCH] xen: fix s3 resume on AMD CPUs, Christoph Egger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
