WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Mon, 23 Mar 2009 20:56:39 +1100
Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Mon, 23 Mar 2009 02:57:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.18 (2008-05-17)
My patch "xend: specify the slot for pass-through devices"
which was included in xen-unstable.hg as changeset 19418:538a64b1ed63
had an omission.

The code included parsing of slots from the configuration file.
And it stored this information in xend. However, it failed
to pass this information on to qemu-xen.

The patch that was posted and applied doesn't break anything, it just
doesn't achieve anything either.

Apologies for this omission, it was removed to test
possible regressions, and unfortunately wasn't replaced
in the version that I posted.

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

--- 

There are qemu-xen companion patches for this change which have been
posted as "ioemu: specify the slot for pass-through devices"

Index: xen-unstable.hg/tools/python/xen/xend/server/pciif.py
===================================================================
--- xen-unstable.hg.orig/tools/python/xen/xend/server/pciif.py  2009-03-23 
19:55:21.000000000 +1100
+++ xen-unstable.hg/tools/python/xen/xend/server/pciif.py       2009-03-23 
20:24:36.000000000 +1100
@@ -87,8 +87,8 @@ class PciController(DevController):
             if vslt is not None:
                 vslots = vslots + vslt + ";"
 
-            back['dev-%i' % pcidevid] = "%04x:%02x:%02x.%01x" % \
-                                        (domain, bus, slot, func)
+            back['dev-%i' % pcidevid] = "%04x:%02x:%02x.%01x@%02x" % \
+                                        (domain, bus, slot, func, vslot)
             back['uuid-%i' % pcidevid] = pci_config.get('uuid', '')
             pcidevid += 1
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel