 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH 1 of 3] fix S3 suspend error
| To: | "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Lu, Guanqun" <guanqun.lu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH 1 of 3] fix S3 suspend error |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Mon, 23 Feb 2009 05:45:28 -0800 |
| Cc: | |
| Delivery-date: | Mon, 23 Feb 2009 05:46:02 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C5C7E15D.318B%keir.fraser@xxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcmViJ8XW4u06P9hSnyHMFu6bUbj2AAKxFsBAAAV/fAAAS33rwABDw3f |
| Thread-topic: | [Xen-devel] [PATCH 1 of 3] fix S3 suspend error |
| User-agent: | Microsoft-Entourage/12.15.0.081119 |
On 23/02/2009 05:15, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote: >> Xen owns a few devices with most as system class, so for >> simplicity interrupt is disabled from start. It's not worthy of touching >> this flow for this simple spinlock issue, imo. :-) > > Can you point out any core devices in modern Linux 2.6 which implement the > suspend_late() or *_noirq() callbacks (those appear to be the ones handled > in device_power_down() with IRQs disabled)? They seem very obsolete/legacy, > and looks to me like we could unconditionally *not* disable IRQs rather than > unconditionally disabling them. Oh, yes, now I see the sysdev_suspend() stuff. Okay, I agree with the patches then. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-users] Re: VT-D RMRR is incorrect, Dustin Henning |
|---|---|
| Next by Date: | Re: [Xen-devel] cpuid bit for relaxed timer handling?, Andrew Lyon |
| Previous by Thread: | Re: [Xen-devel] [PATCH 1 of 3] fix S3 suspend error, Keir Fraser |
| Next by Thread: | [Xen-devel] [PATCH 3 of 3] fix S3 resume error, Guanqun Lu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
