Re: [Xen-devel] [PATCH 1 of 3] fix S3 suspend error

To:	Guanqun Lu <guanqun.lu@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 1 of 3] fix S3 suspend error
From:	Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date:	Mon, 23 Feb 2009 04:38:55 -0800
Cc:
Delivery-date:	Mon, 23 Feb 2009 04:39:32 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<b713518a241b6f6e07ed.1235402867@xxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcmViJ8XW4u06P9hSnyHMFu6bUbj2AAKxFsB
Thread-topic:	[Xen-devel] [PATCH 1 of 3] fix S3 suspend error
User-agent:	Microsoft-Entourage/12.15.0.081119

On 23/02/2009 07:27, "Guanqun Lu" <guanqun.lu@xxxxxxxxx> wrote:

> fix S3 suspend error.
> 
> invoke ioapic_pm_state_alloc() eariler,
> thus avoiding check_lock() BUG_ON() in spin_lock().
> 
> Signed-off-by: Guanqun Lu <guanqun.lu@xxxxxxxxx>

This one I think is a good idea anyway. The other two -- I wonder why we do
device suspend/resume with IRQs disabled? As far as I can tell Linux does
not do that. So would it be cleaner to move the device suspend/resume hooks
outside the IRQs-disabled region?

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 1 of 3] fix S3 suspend error