 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check
| To: | Niraj Tolia <ntolia@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Tue, 06 Jan 2009 22:15:40 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Tue, 06 Jan 2009 14:15:53 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <7e45e2ac0901061037j19a8303eq792603eec4fb4735@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AclwTE7hInrQxOfpVEe2b7wPEF0U3g== |
| Thread-topic: | [Xen-devel] [PATCH] Fix xenoprof counter overflow check |
| User-agent: | Microsoft-Entourage/12.15.0.081119 |
On 06/01/2009 18:37, "Niraj Tolia" <ntolia@xxxxxxxxx> wrote:
> While the mainline patch won't build, the one attached definitely does. That
> said, I see your point about the overflow. Now I need to figure out why this
> broken patch actually enables xenoprof to work on my Intel Xeon. The only
> reason would be the switch from CTR_READ() (which uses rdmsr() internally) to
> rdmsrl() but let me dig into it.
The patch absolutely did not build. There were still references to local
variables ('low' and 'high') that you removed the definitions of.
-- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] xen_phys_start for 32b, Keir Fraser |
|---|---|
| Next by Date: | RE: [Xen-devel] xen_phys_start for 32b, Cihula, Joseph |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check, Niraj Tolia |
| Next by Thread: | Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check, Niraj Tolia |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
