Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check

To:	"Keir Fraser" <keir.fraser@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check
From:	"Niraj Tolia" <ntolia@xxxxxxxxx>
Date:	Tue, 6 Jan 2009 14:24:15 -0800
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 06 Jan 2009 14:24:44 -0800
Dkim-signature:	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type:references; bh=UmnbUU6QsFaXqukWqTLQJO1zqhvgGcOXTvH0DXKcsdE=; b=FCUx7OuVLvQZ3sM7kXS4R3+LZvPk2wSj8tlPGgTvomw5kxbM5sXfLH1QY6IaZOL6LL RMMaNg33IkkrwlDv7VJ15dF19ci8uKYPyEXeWQAByMVsZDSjRmifb1l2fFSSu05hrGd2 iET7oXhua2ReG3DguviZaszNula7YpBUu9dC8=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:references; b=V3d2uR5ueskU1I08clsBga6OMkTT/GTuEHBirXLvPFDuXu2g3X6+5sn3OERmJoWIb4 dFRkdGUJCokkSYJd/z8X1C/i3p6W4MCaYWwftwADASjRW5Bkt2PAMJnKuipl5fwjSZ7u 9YMnemmVPPHWbcjNl5kUPBSHBLT/YVkjPeweo=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<C589888C.20CB8%keir.fraser@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<7e45e2ac0901061037j19a8303eq792603eec4fb4735@xxxxxxxxxxxxxx> <C589888C.20CB8%keir.fraser@xxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On Tue, Jan 6, 2009 at 2:15 PM, Keir Fraser <keir.fraser@xxxxxxxxxxxxx> wrote:

On 06/01/2009 18:37, "Niraj Tolia" <ntolia@xxxxxxxxx> wrote:

> While the mainline patch won't build, the one attached definitely does. That
> said, I see your point about the overflow. Now I need to figure out why this
> broken patch actually enables xenoprof to work on my Intel Xeon. The only
> reason would be the switch from CTR_READ() (which uses rdmsr() internally) to
> rdmsrl() but let me dig into it.

The patch absolutely did not build. There were still references to local
variables ('low' and 'high') that you removed the definitions of.

Ah. My patch was generated against xen-3.3-testing.hg. I just noticed that the same function has a number of changes in xen-unstable and would cause a build failure. Sorry about that.

Niraj

-- Keir

--
Niraj Tolia, Researcher, HP Labs
http://www.hpl.hp.com/personal/Niraj_Tolia/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] Fix xenoprof counter overflow check