WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] NR_PIRQS vs. NR_IRQS

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] NR_PIRQS vs. NR_IRQS
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Thu, 13 Nov 2008 16:59:50 +0000
Delivery-date: Thu, 13 Nov 2008 08:59:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
I'm having some difficulty understanding why these two need to be
distinguished: Depending on the code location, an IRQ passed in from the
guest may be checked against NR_PIRQS (map_domain_pirq() as called
from PHYSDEVOP_alloc_irq_vector) or NR_IRQS (PHYSDEVOP_irq_status_query,
PHYSDEVOP_map_pirq), despite it having the same source.

Also, tying NR_IRQS to NR_VECTORS seems bogus - even with current
code I can't see why we shouldn't be able to support a higher NR_IRQS
without immediately doing the more involved code changes needed to
also grow NR_VECTORS. After all, NR_IRQS is directly tied to the number
of IO-APIC pins we can support - in order to support a device, its
cumulative pin number (being the irq) must be below NR_IRQS. But since
very likely not all pins are connected to devices, NR_VECTORS is much
less of a limiting factor.

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel