WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU

To: Ingo Molnar <mingo@xxxxxxx>
Subject: Re: [Xen-devel] 2.6.27 - SMP enabled, but only 1 CPU
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Thu, 06 Nov 2008 13:20:04 -0800
Cc: Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, xen devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
Delivery-date: Thu, 06 Nov 2008 13:20:48 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081106211639.GA24579@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <48F3BC99.5040409@xxxxxxxxxxxx> <490F5F50.7020704@xxxxxxxxxxxx> <4910AD00.7040605@xxxxxxxxxxxx> <4911BC52.7040905@xxxxxxxxxxxx> <1225994697.12607.837.camel@xxxxxxxxxxxxxxxxxxxxxx> <49134257.4000404@xxxxxxxx> <20081106211639.GA24579@xxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.17 (X11/20081009)
Ingo Molnar wrote:
a "cleanup" impact line is only added if the change is not intended to have any side-effects whatsoever.

We can drop it but it would be really nice to figure out what's going on. In a very quick late-night look i cannot see anything particularly weird about it, but based on the type of changes it does there are three leading candidates: lost high 32 bits, zero extend problem, or incorrect types.

Yeah, I couldn't see anything either. It's a reasonable cleanup (I never did understand that struct page * cast), but its always nicer when cleanups don't break working code ;).

   J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel