WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.

To: Joe Jin <joe.jin@xxxxxxxxxx>
Subject: Re: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 05 Nov 2008 07:39:33 +0000
Cc: Xen-devel@xxxxxxxxxxxxxxxxxxx, kurt.hackel@xxxxxxxxxx, shinya.narahara@xxxxxxxxxx, greg.marsden@xxxxxxxxxx, wen.gang.wang@xxxxxxxxxx, jens.axboe@xxxxxxxxxx
Delivery-date: Tue, 04 Nov 2008 23:39:39 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081105032241.GA17919@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ack/GaTl43H8lKsMEd2X2wAWy6hiGQ==
Thread-topic: [Xen-devel] [patch 0/6] xenblk: Add O_DIRECT and O_SYNC support.
User-agent: Microsoft-Entourage/11.4.0.080122
On 5/11/08 03:22, "Joe Jin" <joe.jin@xxxxxxxxxx> wrote:

>> O_DIRECT has no meaning really across the xenblk interface. The intention is
>> that blkback talks at a raw block device below the buffer cache anyway.
>> 
>> For O_SYNC it can be implemented by pushing out all I/Os into the ring
>> buffer and then wait for all required responses. Why do you think that
>> doesn't work? Indeed it should work already if such logic exists in the
>> generic Linux block layer, since blkfront notifies that layer as responses
>> come in from blkback.
>> 
> Do you think when xenblk backend make_reponse() means the request have
> commited to disk?
> We have did a sample testing and found without BI_RW_SYNC flag setted,
> either O_DIRECT or O_SYNC flag, when vm crashed/power outage, lots of
> data lost, sometimes more than 1M data lost, that means vm under
> high data lost risk. With BI_RW_SYNC flag when call submit_bio, open
> file with O_DIRECT or O_SYNC flag, could sync data very well.

What's the vbd type in this case: raw partition, lvm, qcow file, ...?

The existing BLKIF_OP_WRITE_BARRIER and BLKIF_OP_FLUSH_DISKCACHE should
suffice to implement O_SYNC on the blkfront side, I think. O_DIRECT doesn't
mean writes are synchronous to the platters -- just means the buffer cache
is bypassed -- which should generally be the case on the blkback side always
anyway.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>