Re: [Xen-devel] [RFC][PATCH] add tlsf option for xmalloc

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 15/10/08 20:59, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

>> Structure definitions and the like which are private to TLSF
>> should live at
>> the top of the .c file: I prefer that to the <xen/*_int.h>
>> approach as it
>> keeps private non-shared stuff all in one place.
> 
> Sounds good.
> 
> You may note that the tlsf files borrowed from Nitin Gupta use Linux-style
> indentation/formatting.  One of my reasons for not merging the tlsf
> allocation with xmalloc is I was too lazy to reformat ;-)  Do I need
> to do that or can I leave it as is or do you have a tool that will
> auto-reformat it to meet the Xen style requirements?

If the patch is actually working fine then I can take it and do the
necessary reformatting. It only takes a short while even to do it manually.

You need to provide a signed-off-by line, by the way.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel