WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RFC][PATCH] add tlsf option for xmalloc

To: Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>, "Xen-Devel (E-mail)" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH] add tlsf option for xmalloc
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 15 Oct 2008 19:09:58 +0100
Cc: Nitin Gupta <nitingupta910@xxxxxxxxx>
Delivery-date: Wed, 15 Oct 2008 11:10:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <c33878a9-d80d-4c28-8368-152d616fb1f3@default>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acku8TutenrgQ5rkEd2JPwAWy6hiGQ==
Thread-topic: [Xen-devel] [RFC][PATCH] add tlsf option for xmalloc
User-agent: Microsoft-Entourage/11.4.0.080122
On 15/10/08 18:47, "Dan Magenheimer" <dan.magenheimer@xxxxxxxxxx> wrote:

> Note that this is compile-tested but not run tested yet.  I
> thought I'd get feedback on the approach before I get much
> further.

The approach is fine as far as I'm concerned. It should just replace the
existing xmalloc.c of course: no point in keeping the old one around.
Therefore may as well put the whole implementation in xmalloc.c, or call it
xmalloc_tlsf.c if you're really keen to keep the name of the algorithm in
the file name (in which case xmalloc.c should be entirely deleted; or
perhaps temporarily make it a build option which .c file gets built if
really worried that the new xmalloc implementation may have subtle bugs and
we'd like to be able to revert for testing).

Structure definitions and the like which are private to TLSF should live at
the top of the .c file: I prefer that to the <xen/*_int.h> approach as it
keeps private non-shared stuff all in one place.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>