| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] Windows Bug Check 0x101 issue
|
To: |
Kouya Shimura <kouya@xxxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] Windows Bug Check 0x101 issue |
|
From: |
Alan Cox <alan@xxxxxxxxxxxxxxxxxxx> |
|
Date: |
Thu, 27 Mar 2008 09:08:31 +0000 |
|
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Samuel Thibault <samuel.thibault@xxxxxxxxxxxxx> |
|
Delivery-date: |
Thu, 27 Mar 2008 02:25:55 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<7ktziseo9r.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 |
|
References: |
<7k4pawfnxs.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> <C40D3B88.15566%keir.fraser@xxxxxxxxxxxxx> <7k1w5zf50j.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> <18408.57824.846687.465435@xxxxxxxxxxxxxxxxxxxxxxxx> <20080325175718.GT4411@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <7ky786dkup.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> <18410.9596.488204.878357@xxxxxxxxxxxxxxxxxxxxxxxx> <7ktziseo9r.fsf@xxxxxxxxxxxxxxxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, 27 Mar 2008 14:20:32 +0900
Kouya Shimura <kouya@xxxxxxxxxxxxxx> wrote:
> Ian Jackson writes:
> > This one is much better but I still have a comment ...
>
> Thank you for many comments. Actually I'm not good at qemu.
> How about the attached patch?
>
> > > +static void ide_flush_cb(void *opaque, int ret)
> > > +{
> > > + IDEState *s = opaque;
> > > +
> > > + s->status = READY_STAT;
> > > + ide_set_irq(s);
> >
> > You need to check the return value (ret) and set an appropriate IDE
> > error status if the operation failed. ide_abort_command may be of
> > some use.
>
> This patch uses ide_abort_command().
> As for the failure case, it looks too much for me.
> I hope someone who is expert on the IDE fixes it.
If a flush fails you can't just just reply with an abrt as I said earlier,
many OS will then loop forever trying to finish the flush. flush cache
has unusual error reporting behaviour (see ATA-7). An abort means a cache
flush fail and to retry for further sectors, if you can't properly
emulate reporting block numbers back then you need to offline the virtual
device.
Alan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home