Re: [Xen-devel] [PATCH 1/4] tools - Remove machine setting from HOSTCFLAGS

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 27/1/08 10:55, "Bastian Blank" <bastian@xxxxxxxxxxxx> wrote:

>> Unfortunately those lines *were* introduced for a reason. See the thread at
>> http://lists.xensource.com/archives/html/xen-devel/2007-08/msg00342.html. In
>> brief summary, the HOSTCFLAGS mod ensures that Solaris gcc produces 64-bit
>> binaries when COMPILE_ARCH==x86_64; a sane thing to do you'll agree.
> 
> Your summary not complete. The build assumes the HOSTCC is able to
> produce binaries which both run on the host and match the target
> environment.

Not sure what you mean? You think HOSTCC needs special casing too?

>> We could move the HOSTCFLAGS modification to config/SunOS.mk. Or to
>> tools/include/xen-foreign/Makefile. But actually afaict doing it globally in
>> Config.mk is harmless, it just looks a bit odd and potentially purgable. :-)
> 
> It just missuses the name HOST, IMHO.
> 
> Anyway, why not the following patch? It removes the special case in
> mkchecker.py and always checks if all _translated_ structs have the
> correct size. This should catch both error cases: orig struct was
> changed and translation is broken. Also it can run always now. Or is
> it a fix for something else to do the check this way and forget the
> translated one?

Your patch might make sense. I'll take a look.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel