WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/4] tools - Remove machine setting from HOSTCFLA

To: Bastian Blank <bastian@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/4] tools - Remove machine setting from HOSTCFLAGS
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sun, 27 Jan 2008 11:09:23 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, John Levon <levon@xxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 27 Jan 2008 03:09:43 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080127105546.GA933@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Achg1RI3UOCK7czIEdyMOAAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH 1/4] tools - Remove machine setting from HOSTCFLAGS
User-agent: Microsoft-Entourage/11.3.6.070618
On 27/1/08 10:55, "Bastian Blank" <bastian@xxxxxxxxxxxx> wrote:

>> Unfortunately those lines *were* introduced for a reason. See the thread at
>> http://lists.xensource.com/archives/html/xen-devel/2007-08/msg00342.html. In
>> brief summary, the HOSTCFLAGS mod ensures that Solaris gcc produces 64-bit
>> binaries when COMPILE_ARCH==x86_64; a sane thing to do you'll agree.
> 
> Your summary not complete. The build assumes the HOSTCC is able to
> produce binaries which both run on the host and match the target
> environment.

Not sure what you mean? You think HOSTCC needs special casing too?

>> We could move the HOSTCFLAGS modification to config/SunOS.mk. Or to
>> tools/include/xen-foreign/Makefile. But actually afaict doing it globally in
>> Config.mk is harmless, it just looks a bit odd and potentially purgable. :-)
> 
> It just missuses the name HOST, IMHO.
> 
> Anyway, why not the following patch? It removes the special case in
> mkchecker.py and always checks if all _translated_ structs have the
> correct size. This should catch both error cases: orig struct was
> changed and translation is broken. Also it can run always now. Or is
> it a fix for something else to do the check this way and forget the
> translated one?

Your patch might make sense. I'll take a look.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel