WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 1/4] tools - Remove machine setting from HOSTCFLA

To: Bastian Blank <bastian@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 1/4] tools - Remove machine setting from HOSTCFLAGS
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sun, 27 Jan 2008 09:43:12 +0000
Cc: John Levon <levon@xxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 27 Jan 2008 01:43:28 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080126193414.GA2278@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchgyQgPRqyiEsy8EdyMOAAWy6hiGQ==
Thread-topic: [Xen-devel] [PATCH 1/4] tools - Remove machine setting from HOSTCFLAGS
User-agent: Microsoft-Entourage/11.3.6.070618
On 26/1/08 19:34, "Bastian Blank" <bastian@xxxxxxxxxxxx> wrote:

> # HG changeset patch
> # User Bastian Blank <waldi@xxxxxxxxxx>
> # Date 1201375662 -3600
> # Node ID 15419f59710aeaaf83fc35fbbf955b15ec713051
> # Parent  c98a1a50be44c52cb59b5795347bf852941b4fdc
> Remove machine setting from HOSTCFLAGS.
> 
> The host compiler must know how to produce runnable binaries without
> special settings.
> 
> Signed-off-by: Bastian Blank <waldi@xxxxxxxxxx>

Unfortunately those lines *were* introduced for a reason. See the thread at
http://lists.xensource.com/archives/html/xen-devel/2007-08/msg00342.html. In
brief summary, the HOSTCFLAGS mod ensures that Solaris gcc produces 64-bit
binaries when COMPILE_ARCH==x86_64; a sane thing to do you'll agree.

We could move the HOSTCFLAGS modification to config/SunOS.mk. Or to
tools/include/xen-foreign/Makefile. But actually afaict doing it globally in
Config.mk is harmless, it just looks a bit odd and potentially purgable. :-)

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel