Re: [Xen-devel] PATCH: Remove execute permission from xend-debug.log

[Aron Griffis <aron@xxxxxx>]

Aron Griffis wrote:  [Tue Apr 24 2007, 05:39:41PM EDT]
> Daniel P. Berrange wrote:  [Tue Apr 24 2007, 03:22:11PM EDT]
> > The file /var/log/xen/xend-debug.log is currently being created with 
> > executable permission bits set. This is because the os.open() method
> > defaults to using a mode of 0777 if no third parameter is provided.
> > The attached patch changes the mode to 0600 to ensure that the file
> > permissions come out as -rw-------  instead of -rwxr-xr-x
> 
> Doesn't os.open default to 0777 & ~umask?  Doesn't seem like xend
> should be overriding root's umask

Seems that the patch should be using 0666 instead of 0600 so that
umask can affect group/other perms.  At the very least it should use
0664.

Aron

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel