This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to s

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable
From: Steven Rostedt <srostedt@xxxxxxxxxxx>
Date: Fri, 16 Mar 2007 15:35:44 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, William Lee Irwin III <wli@xxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, Ingo Molnar <mingo@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 19 Mar 2007 03:47:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45FAE46F.7080009@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Kihon Technologies Inc.
References: <20070301232443.195603797@xxxxxxxx> <20070301232526.611972133@xxxxxxxx> <20070316093348.GS23174@xxxxxxx> <45FAE46F.7080009@xxxxxxxx>
Reply-to: rostedt@xxxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2007-03-16 at 11:39 -0700, Jeremy Fitzhardinge wrote:
> Ingo Molnar wrote:
> >> +  /* Make sure kernel address space is empty so that a pagetable
> >> +     will be allocated for it. */
> >>     
> >
> > comment style.
> >   
> As you've noticed its a comment style I use quite often.  I use it for
> what's essentially a little local comment, rather than a block comment
> which really needs to draw attention to itself.  In this case, I think using

Understood, but then you need to make that comment a single line :)

The way Linux code prefers comments (like the code itself actually
prefers it!) is single line comments stay on a single line, and
multiline comments are always block.

So it's either:

   /* my little comment here */


    * This comment, although small and to the point, does span multiple
    * lines and regardless, needs to be a block comment.

I guess it just makes it easier on the eyes when everything conforms and
others need to look at / maintain your code.

-- Steve

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>