| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
[Xen-devel] Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to s
|
To: |
Jeremy Fitzhardinge <jeremy@xxxxxxxx> |
|
Subject: |
[Xen-devel] Re: [patch 05/26] Xen-paravirt_ops: paravirt_ops: hooks to set up initial pagetable |
|
From: |
Ingo Molnar <mingo@xxxxxxx> |
|
Date: |
Fri, 16 Mar 2007 10:33:48 +0100 |
|
Cc: |
Zachary Amsden <zach@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, virtualization@xxxxxxxxxxxxxx, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, William Lee Irwin III <wli@xxxxxxxxxxxxxx>, Chris Wright <chrisw@xxxxxxxxxxxx>, Andi Kleen <ak@xxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
|
Delivery-date: |
Fri, 16 Mar 2007 02:33:28 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<20070301232526.611972133@xxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20070301232443.195603797@xxxxxxxx> <20070301232526.611972133@xxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
|
User-agent: |
Mutt/1.4.2.2i |
* Jeremy Fitzhardinge <jeremy@xxxxxxxx> wrote:
> This patch introduces paravirt_ops hooks to control how the kernel's
> initial pagetable is set up.
looks good. Some minor nits:
> + /* Make sure kernel address space is empty so that a pagetable
> + will be allocated for it. */
comment style.
> + /* Enable PSE if available */
> + if (cpu_has_pse) {
> + set_in_cr4(X86_CR4_PSE);
> + }
unnecessary braces.
Ingo
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home