This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] return value checking on multicalls

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] return value checking on multicalls
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 14 Mar 2007 16:00:12 +0000
Delivery-date: Wed, 14 Mar 2007 08:59:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45F828EB.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdmUdjbF2+ksdJFEdu8zgAX8io7RQ==
Thread-topic: [Xen-devel] return value checking on multicalls
User-agent: Microsoft-Entourage/
On 14/3/07 15:55, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Many places currently don't even check HYPERVISOR_multicall()'s return
> value, not to speak of checking the individual status codes. Would it be
> acceptable to add an argument to this function to request to either fold
> all status values into a global success code, or to force BUG_ON() each
> individual status. Or should I rather add a new function with described
> behavior? Or are there other suggestions?

I think a separate function would be neater, but I'm not sure what you'd
call it. :-) The general idea seems a good one.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>