WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] RFC: vaddr_t and vsize_t

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] RFC: vaddr_t and vsize_t
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Thu, 18 Jan 2007 08:13:01 +0100
Cc: Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Wed, 17 Jan 2007 23:19:12 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1D404AE.7C3D%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: AMD / OSRC
References: <C1D404AE.7C3D%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.4
On Wednesday 17 January 2007 17:51, Keir Fraser wrote:
> On 17/1/07 16:21, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > This stuff is about removing a place where programmers can make mistakes.
> > vaddr_t also avoids void * arithmetics. It should be possible then to use
> > -Wpointer-arith.
>
> A bunch of our void* arithmetic comes from files we keep in sync with
> Linux. So we'd really need Linux to clean this up before we use
> -Wpointer-arith, or we have to do extra porting effort to keep files in
> sync.

Well, actually I'm talking about the Xen-kernel and not about the 
Linux-kernel.

> I suppose I don't mind vaddr_t being defined and people using it if they
> want to. At least it is probably clearer that translation to/from char* or
> long to do pointer arithmetic. However, I'm less sure about a wholesale
> conversion of Xen away from use of 'unsigned long'.

Ok. I will prepare a patch. Someone has to make the start. :-)




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>