Re: [Xen-devel] [BUGFIX][ACM] fix return code in acm-related xm scripts

[Reiner Sailer <sailer@xxxxxxxxxx>]

Hi Masaki,

correct. 

This return slipped through. I'll add
your case to the patch and resubmit the patch.

Thanks!

Reiner
__________________________________________________________
Reiner Sailer, Research Staff Member, Secure Systems Department
IBM T J Watson Research Ctr, 19 Skyline Drive, Hawthorne NY 10532
Phone: 914 784 6280  (t/l 863)  Fax: 914 784 6205, sailer@xxxxxxxxxx
 
http://www.research.ibm.com/people/s/sailer/

Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

09/11/2006 04:20 AM

To	Reiner Sailer/Watson/IBM@IBMUS, xen-devel@xxxxxxxxxxxxxxxxxxx
cc
Subject	Re: [Xen-devel] [BUGFIX][ACM] fix return code in acm-related xm scripts

Hi Reiner,

It's very nice of you to make patch.

I have a small comment.
I think that the following correction is necessary.

diff -r 7acaba46e15e tools/python/xen/xm/getlabel.py
--- a/tools/python/xen/xm/getlabel.py        
        Fri Sep 08 15:46:54 2006 -0700
+++ b/tools/python/xen/xm/getlabel.py        
        Mon Sep 11 16:49:42 2006 +0900
@@ -47,7 +45,7 @@ def get_resource_label(resource):
         label = access_control[resource][1]
         print "policy="+policy+",label="+label
     else:
-        print "Resource not labeled"
+        security.err("Resource not labeled")


Best regards,
 Kan

>This patch fixes return codes for the acm-related Xen management scripts
>(error conditions) and addresses minor issues that 'pycheck' complains
>about. It is tested with xm-test and by manually running the xm commands.
>
>Signed-off by: Reiner Sailer <sailer@xxxxxxxxxx>
>
>
>-------------------------------text/plain-------------------------------
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel