 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [BUGFIX][ACM] fix return code in acm-related xm scripts
| To: | Reiner Sailer <sailer@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | Re: [Xen-devel] [BUGFIX][ACM] fix return code in acm-related xm scripts |
| From: | Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx> |
| Date: | Mon, 11 Sep 2006 17:20:17 +0900 |
| Delivery-date: | Mon, 11 Sep 2006 01:21:22 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4501A812.80600@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <4501A812.80600@xxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Hi Reiner,
It's very nice of you to make patch.
I have a small comment.
I think that the following correction is necessary.
diff -r 7acaba46e15e tools/python/xen/xm/getlabel.py
--- a/tools/python/xen/xm/getlabel.py Fri Sep 08 15:46:54 2006 -0700
+++ b/tools/python/xen/xm/getlabel.py Mon Sep 11 16:49:42 2006 +0900
@@ -47,7 +45,7 @@ def get_resource_label(resource):
label = access_control[resource][1]
print "policy="+policy+",label="+label
else:
- print "Resource not labeled"
+ security.err("Resource not labeled")
Best regards,
Kan
>This patch fixes return codes for the acm-related Xen management scripts
>(error conditions) and addresses minor issues that 'pycheck' complains
>about. It is tested with xm-test and by manually running the xm commands.
>
>Signed-off by: Reiner Sailer <sailer@xxxxxxxxxx>
>
>
>-------------------------------text/plain-------------------------------
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] update for x86_64-put-note-sections-into-a-pt_note-segment-in-vmlinux.patch, Jan Beulich |
|---|---|
| Next by Date: | Re: [Xen-devel] Re: Oops when loading xen_platform_pci module in HVM domain on CS 11429, Steven Smith |
| Previous by Thread: | [Xen-devel] [BUGFIX][ACM] fix return code in acm-related xm scripts, Reiner Sailer |
| Next by Thread: | Re: [Xen-devel] [BUGFIX][ACM] fix return code in acm-related xm scripts, Reiner Sailer |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
